-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restart indexing pipeline on index update #5265
Conversation
40ae187
to
9c5d6f2
Compare
this still needs automated tests, but should otherwise be ready for a first round of review |
It would be great to add a test this in https://github.com/quickwit-oss/quickwit/blob/main/quickwit/quickwit-integration-tests/src/tests/update_tests/doc_mapping_tests.rs |
5395840
to
da62963
Compare
da62963
to
61d3622
Compare
thinking about it, as we only restart indexing pipelines, but don't do anything about shards, shards from ingest-v2 could have a stall doc_mapping, and if validation is enabled, they could reject documents that are valid under the new mapping. Ideally we'd want to also close all shards for the index and open as many new ones. |
Description
restart indexing pipelines on index update
part of #5084
How was this PR tested?
todo