upgrade aws-sdk #4918
Merged
upgrade aws-sdk #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AMAZING |
|
AMAZING++ |
|
no wayyyyyyyyyy! |
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
| StorageErrorKind::Internal | ||
| .with_error(anyhow!("failed to build object identifier")), | ||
| ); | ||
| unattempted.extend(chunk.iter().map(|path| path.to_path_buf())); |
There was a problem hiding this comment.
that code logic is not good:
we batch things in chunk... If one of the object is wrong in the chunk we ditch the entire chunk, but not the entire request, even though at this point not request happened.
This does not make much sense. Chunking should happen after creating the object identifier.
The code woudl be simpler and the spec would make way more sense.
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
reviewed
Apr 29, 2024
fulmicoton
requested changes
Apr 29, 2024
fulmicoton
approved these changes
May 1, 2024
fulmicoton
reviewed
May 1, 2024
| @@ -643,7 +675,7 @@ impl S3CompatibleObjectStorage { | |||
| } | |||
| Err(delete_objects_error) => { | |||
| error = Some(delete_objects_error.into()); | |||
| unattempted.extend(chunk.iter().map(|path| path.to_path_buf())); | |||
| unattempted.extend(chunk.iter().map(|(path, _oid)| path.to_path_buf())); | |||
There was a problem hiding this comment.
This is technically incorrect. These path have been attempted.
For instance, at this point, they might be deleted.
fulmicoton
approved these changes
May 1, 2024
|
I did not include this PR in the 0501 airmail test to avoid risk, but we can try that next time. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4822
How was this PR tested?
updated unit tests