Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc section about secured Kafka #4796

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Add doc section about secured Kafka #4796

merged 5 commits into from
Apr 25, 2024

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Mar 26, 2024

Description

It is common to used an externally managed Kafka service. In that case authentication is necessary, and it would be good to show that we support it.

How was this PR tested?

Ran tests using aiven.io and the Quickwit Docker distribution.

@rdettai rdettai self-assigned this Mar 26, 2024
@rdettai rdettai marked this pull request as ready for review March 26, 2024 08:27
@rdettai rdettai requested a review from fmassot March 26, 2024 08:27
@rdettai
Copy link
Collaborator Author

rdettai commented Mar 26, 2024

@fmassot should we recommend one of SSL or SASL? I'm a bit bothered by the fact that the SASL password ends up being stored clear text in the metastore. I feel SSL is a bit better in that regard because the secrets stay on the Quickwit instances.

@rdettai rdettai added the documentation Improvements or additions to documentation label Mar 26, 2024
Copy link
Member

@guilload guilload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

docs/ingest-data/kafka.md Outdated Show resolved Hide resolved
docs/ingest-data/kafka.md Outdated Show resolved Hide resolved
docs/ingest-data/kafka.md Outdated Show resolved Hide resolved
@rdettai rdettai merged commit d48b6ab into main Apr 25, 2024
4 checks passed
@rdettai rdettai deleted the secured-kafka branch April 25, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants