Fix race condition related to debouncing. #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
race-condition-due-to-debouncing
branch
3 times, most recently
from
4b9fa26 to
25631f1
Compare
fulmicoton
changed the title
In Ingest v1, queues are created on apply plans. This means that right after creating an index, documents cannot be inserted. This was true before, but was dependent on a race condition. It became more apparent after we added debouncing of control plane apply plans. This PR adds code to make it possible for caller of debounced rebuild plan code, to get notified and wait for a rebuild to be done and applied.
fulmicoton
force-pushed
the
race-condition-due-to-debouncing
branch
from
25631f1 to
0055b2d
Compare
guilload
approved these changes
Mar 7, 2024
quickwit/quickwit-control-plane/src/indexing_scheduler/change_tracker.rs
Show resolved
Hide resolved
Co-authored-by: Adrien Guillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ingest v1, queues are created on apply plans.
This means that right after creating an index, documents cannot be inserted.
This was true before, but was dependent on a race condition. It became more apparent after we added debouncing of control plane apply plans.
This PR adds code to make it possible for caller of debounced rebuild plan code, to get notified and wait for a rebuild to be done and applied.