document search after #4265
Merged
document search after #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trinity-1686a
force-pushed
the
trinity--doc-search-after
branch
from
c1ef364 to
dcf4de7
Compare
|
Can you add an example and explain that timestamp must be expressed in nanoseconds? |
fmassot
reviewed
Dec 12, 2023
docs/reference/es_compatible_api.md
Outdated
| @@ -169,7 +169,7 @@ following syntax. | |||
| { | |||
| // ... | |||
| "sort" : [ | |||
| { "timestamp" : {"order" : "asc"}}, | |||
| { "timestamp" : {"format": "epoch_millis","order" : "asc"}}, | |||
There was a problem hiding this comment.
surprise..... I went for epoch_millis_as_int format as elasticsearch returns milliseconds as strings with format epoch_millis. Thus I added the ugly as_int to avoid confusion ://///
Suggested change
| { "timestamp" : {"format": "epoch_millis","order" : "asc"}}, | |
| { "timestamp" : {"format": "epoch_millis_as_int","order" : "asc"}}, |
fmassot
reviewed
Dec 12, 2023
| @@ -353,7 +353,7 @@ fn validate_sort_by_field( | |||
| has_timestamp_format: bool, | |||
| schema: &Schema, | |||
| ) -> crate::Result<()> { | |||
| if field_name == "_score" { | |||
| if ["_score", "_shard_doc", "_doc"].contains(&field_name) { | |||
There was a problem hiding this comment.
oh, thank you for fixing this; I totally forgot it.
Do we have tests on this?
There was a problem hiding this comment.
I don't think so
fmassot
approved these changes
Dec 12, 2023
|
Approved, can you just take into account my minor comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4077
I'm not sure what to add more than that line.
somewhat unrelated, document possible improvements to the
partial_request_cache, that apply particularly to search_after