Add extra headers in rest config and move rest parameters into rest config section #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
force-pushed
the
es_header
branch
4 times, most recently
from
b6b2022 to
7b457cb
Compare
* Update config with additional headers. * Move rest_listen_port into rest config. * Update docs/configuration/node-config.md Co-authored-by: Adrien Guillo <[email protected]> * Update docs/configuration/node-config.md Co-authored-by: Adrien Guillo <[email protected]> * Update docs/configuration/node-config.md Co-authored-by: Adrien Guillo <[email protected]> * Clean. --------- Co-authored-by: Adrien Guillo <[email protected]>
fmassot
changed the title
guilload
approved these changes
Dec 4, 2023
Co-authored-by: Adrien Guillo <[email protected]>
fmassot
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will get
the client noticed that the server is not Elasticsearch and we do not support this unknown producterror message when querying the Qucikwit with the Golang client.That's because some Elasticsearch clients will check the response header whether the heads contain
X-Elastic-Productand the value isElasticsearchSource code in Elasticsearch clients
How was this PR tested?
test code https://github.com/quickwit-oss/quickwit/compare/es_header?expand=1#diff-ff71f681357dc97850f21fb99bd77c44304e9c20b043c1de8182e48ef206208fR415