Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digital Ocean storage flavor #3632

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add Digital Ocean storage flavor #3632

merged 1 commit into from
Jul 17, 2023

Conversation

guilload
Copy link
Member

Description

  • Add Digital Ocean storage flavor
  • Fix MinIO flavor

How was this PR tested?

  • Added unit tests
  • Run the following integrating test on Digital Ocean:
fn test_suite_on_s3_storage_path_style_access() {
    let s3_storage_config = S3StorageConfig {
        force_path_style_access: true,
        disable_multi_object_delete: true,
        ..Default::default()
    };
    let bucket_uri = append_random_suffix("s3://quickwit-integration-tests/test-path-style-access");
    let test_runtime = test_runtime_singleton();
    test_runtime.block_on(run_s3_storage_test_suite(s3_storage_config, &bucket_uri));
}
AWS_PROFILE=do \
AWS_REGION=nyc3 \
QW_S3_ENDPOINT=https://quickwit-integration-tests.nyc3.digitaloceanspaces.com \
cargo test --manifest-path quickwit/Cargo.toml -p quickwit-storage --all-features -- test_suite_on_s3_storage_path_style_access

@guilload guilload requested a review from trinity-1686a July 13, 2023 21:35
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you also update docs/configuration/node-config.md with the new flavor?

@guilload guilload force-pushed the guilload/do-storage-flavor branch from b3d585a to 8fc7105 Compare July 17, 2023 08:57
@guilload guilload merged commit de113c9 into main Jul 17, 2023
@guilload guilload deleted the guilload/do-storage-flavor branch July 17, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants