Add a quickwit-integration-tests crate #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
reviewed
Apr 20, 2023
quickwit/quickwit-integration-tests/src/test_utils/test_client.rs
Outdated
Show resolved
Hide resolved
fmassot
reviewed
Apr 20, 2023
| @@ -80,7 +81,12 @@ impl RunCliCommand { | |||
| quickwit_telemetry::send_telemetry_event(telemetry_event).await; | |||
| // TODO move in serve quickwit? | |||
| start_actor_runtimes(&config.enabled_services)?; | |||
| serve_quickwit(config).await?; | |||
| let _ = serve_quickwit(config, async move { | |||
There was a problem hiding this comment.
I think we should take into account other signals (I had this kind of stuff in mind
I suggest to do that in another PR so that you can advance on your original issue :)
There was a problem hiding this comment.
There is an issue related to this #3073
fmassot
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2984
How was this PR tested?
The whole PR is basically a test infrastructure.