switch from serde_json to postcard #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
update_tan
branch
4 times, most recently
from
d0ae9eb to
531602d
Compare
PSeitz
changed the title
PSeitz
force-pushed
the
update_tan
branch
2 times, most recently
from
3b7dc58 to
93586b2
Compare
fulmicoton
reviewed
Apr 25, 2023
fulmicoton
reviewed
Apr 25, 2023
PSeitz
force-pushed
the
update_tan
branch
2 times, most recently
from
f33515d to
0e079a3
Compare
switch to postcard for better datastructure support when sending intermediate results between nodes
PSeitz
changed the title
fulmicoton
reviewed
Apr 27, 2023
fulmicoton
reviewed
Apr 27, 2023
fulmicoton
reviewed
Apr 27, 2023
fulmicoton
approved these changes
Apr 27, 2023
Co-authored-by: Paul Masurel <[email protected]>
Co-authored-by: Paul Masurel <[email protected]>
guilload
reviewed
Apr 28, 2023
| pub intermediate_aggregation_result: ::core::option::Option< | ||
| ::prost::alloc::string::String, | ||
| ::prost::alloc::vec::Vec<u8>, |
There was a problem hiding this comment.
We should use Bytes. It's better because it's cheaply cloneable. It makes a difference when coupled with some retry logic that potentially copies the same request multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to postcard for better datastructure support when sending intermediate results between nodes
Percentiles aggregation is broken currently. This fixes that