-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi language tokenizer #3145
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
commented
Apr 7, 2023
fmassot
commented
Apr 7, 2023
fmassot
force-pushed
the
fmassot/multilanguage-tokenizer
branch
from
April 7, 2023 11:56
b5bd1b1
to
ad66f22
Compare
fmassot
changed the title
Add multilanguage tokenizer (WIP)
Add multi language tokenizer (WIP)
Apr 7, 2023
fmassot
force-pushed
the
fmassot/multilanguage-tokenizer
branch
2 times, most recently
from
April 13, 2023 16:23
78e96aa
to
190efed
Compare
fmassot
changed the title
Add multi language tokenizer (WIP)
Add multi language tokenizer
Apr 13, 2023
fmassot
commented
Apr 13, 2023
# This is actually not used directly the goal is to fix the version | ||
# used by reqwest. 0.8.30 has an unclear license. | ||
encoding_rs = "=0.8.29" | ||
# used by reqwest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license is clear: (Apache-2.0 OR MIT) AND BSD-3-Clause so no pb here.
fmassot
force-pushed
the
fmassot/multilanguage-tokenizer
branch
from
April 13, 2023 16:34
190efed
to
5405a08
Compare
fmassot
force-pushed
the
fmassot/multilanguage-tokenizer
branch
from
April 14, 2023 14:40
c347ff1
to
56d44c3
Compare
fmassot
force-pushed
the
fmassot/multilanguage-tokenizer
branch
from
April 14, 2023 22:32
8fb2664
to
a757c3b
Compare
Closing, will open a new PR soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple multi-language tokenizer with language detection.
Fix #3055
TODO
{language-identifier}:
ormulti_language
multilanguage
SimpleTokenStream
in tantivy main branchBinary size
On macOS, using Lindera with the compress features adds 44 MB (97MB -> 141MB).
Benchmarks
Mapping example: