Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track_total_hits of elasticsearch_api's SearchBody is ignored #4705

Closed
RaphaelMarinier opened this issue Mar 8, 2024 · 0 comments · Fixed by #4710
Closed

track_total_hits of elasticsearch_api's SearchBody is ignored #4705

RaphaelMarinier opened this issue Mar 8, 2024 · 0 comments · Fixed by #4710
Assignees
Labels
bug Something isn't working

Comments

@RaphaelMarinier
Copy link
Collaborator

Describe the bug
track_total_hits in the Elastic Search API can be specified in two places:

However, in Quickwit, SearchBody.track_total_hits is ignored. Only SearchQueryParams.track_total_hits is taken into account.

Expected behavior
Both SearchBody.track_total_hits and SearchQueryParams.track_total_hits should be taken into account there:

let count_hits = match search_params.track_total_hits {

According to this ES doc, if both are specified, the one in SearchQueryParams wins.

@RaphaelMarinier RaphaelMarinier added the bug Something isn't working label Mar 8, 2024
PSeitz added a commit that referenced this issue Mar 11, 2024
PSeitz added a commit that referenced this issue Mar 11, 2024
PSeitz added a commit that referenced this issue Mar 11, 2024
PSeitz added a commit that referenced this issue Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants