-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fast field precision
parameter to fast_precision
#3946
Comments
Hello there, I am kind of new to Rust and trying explore good first issues to get myself acquainted with it. I stumbled upon this issue and quickwit caught my eye. I want to try and solve this issue but am confused about something. Here are the steps that I figured I'll have to do: 1.Update the Mapping File: Modify the index configuration mapping file, replacing the occurrence of precision with fast_precision. Now forgive me if I sound stupid but should this be enough or is there something specific I'll have to do for the backward compatibility? That is the part that confuses me, what exactly is needed to be done to ensure backward compatibility? |
Hello @Harsh1s, Yes, for preserving backward compatibility, we need to add a serde alias attribute on the renamed |
There is some confusion between the stored precision, which is always in nanoseconds, vs. the fast field precision which is configurable. The current naming scheme does not help.
Let's rename the fast field
precision
parameter tofast_precision
. We can do so in a backward-compatible manner. The fix should also update the docs and the configuration examples inconfig/
and other places (rg
forprecision: sec|mil|mic|nan
).See discussion in #3940.
The text was updated successfully, but these errors were encountered: