Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake build support #23

Closed
wants to merge 4 commits into from
Closed

Conversation

madmongo1
Copy link
Contributor

Hi there,

I am finding wise_enum very useful but we have standardised on cmake and hunter as a build system and dependency manager.

In order to make that seamless, it's helpful to build a standard cmake script which supports installing the product and the config files.

This PR addresses only this. No code as been changed.

@madmongo1
Copy link
Contributor Author

removed all the clion project files

@@ -0,0 +1,30 @@

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty strange that this is here, is this an accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably my IDE doing some whitespace shenanigans.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean the whole license. The code already has a license, there isn't really a need to have another, nor lists of authors, nor companies.

@quicknir
Copy link
Owner

quicknir commented May 1, 2019

@madmongo1 can you clarify for me, which version of cmake are you targeting?

Sorry for the delay reviewing, I'll keep it speedy from here out.

@madmongo1
Copy link
Contributor Author

madmongo1 commented May 1, 2019 via email

@madmongo1
Copy link
Contributor Author

madmongo1 commented May 1, 2019 via email

@quicknir
Copy link
Owner

quicknir commented May 1, 2019

@madmongo1 can you clarify; you are ok with me taking the PR without the license/authorship list, or not? It wasn't clear to me from your comment.

@madmongo1
Copy link
Contributor Author

madmongo1 commented May 2, 2019 via email

@quicknir
Copy link
Owner

Closed in favor of #24

@quicknir quicknir closed this May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants