-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cmake build support #23
Conversation
removed all the clion project files |
@@ -0,0 +1,30 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty strange that this is here, is this an accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably my IDE doing some whitespace shenanigans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean the whole license. The code already has a license, there isn't really a need to have another, nor lists of authors, nor companies.
@madmongo1 can you clarify for me, which version of cmake are you targeting? Sorry for the delay reviewing, I'll keep it speedy from here out. |
Hi there,
I use very recent cmake (3.13 or 3.14). I can't imagine why anyone would
use an older one.
…On Wed, 1 May 2019 at 05:15, Nir Friedman ***@***.***> wrote:
@madmongo1 <https://github.com/madmongo1> can you clarify for me, which
version of cmake are you targeting?
Sorry for the delay reviewing, I'll keep it speedy from here out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHOZSNSHAAUZ65M6BDKXNDPTEDNDANCNFSM4HG2PU5Q>
.
--
Richard Hodges
[email protected]
office: +442032898513
home: +376841522
mobile: +376380212
|
That part of the code was taken from Ruslo's example which contains his
copyright. I did the work while being paid by Quoine corp, so feel
obligated to put their name on it.
What you do is up to you.
…On Wed, 1 May 2019 at 16:25, Nir Friedman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cmake/Config.cmake.in
<#23 (comment)>:
> @@ -0,0 +1,30 @@
+
No, I mean the whole license. The code already has a license, there isn't
really a need to have another, nor lists of authors, nor companies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABHOZSKGCDBDUEKKZDLS2G3PTGR6BANCNFSM4HG2PU5Q>
.
--
Richard Hodges
[email protected]
office: +442032898513
home: +376841522
mobile: +376380212
|
@madmongo1 can you clarify; you are ok with me taking the PR without the license/authorship list, or not? It wasn't clear to me from your comment. |
I think in this case the code is trivial enough that it can be removed.
Please go ahead and remove the license and authorship
…On Thu, 2 May 2019 at 00:05, Nir Friedman ***@***.***> wrote:
@madmongo1 <https://github.com/madmongo1> can you clarify; you are ok
with me taking the PR without the license/authorship list, or not? It
wasn't clear to me from your comment.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABHOZSPJJF3ZBJMJMQLVTVTPTIH4HANCNFSM4HG2PU5Q>
.
--
Richard Hodges
[email protected]
office: +442032898513
home: +376841522
mobile: +376380212
|
Closed in favor of #24 |
Hi there,
I am finding wise_enum very useful but we have standardised on cmake and hunter as a build system and dependency manager.
In order to make that seamless, it's helpful to build a standard cmake script which supports installing the product and the config files.
This PR addresses only this. No code as been changed.