Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize tag value parsing #657

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Optimize tag value parsing #657

merged 1 commit into from
Aug 9, 2024
+22 −1

Conversation

sylr
Copy link
Contributor

@sylr sylr commented Jul 17, 2024 

goos: darwin
goarch: arm64
pkg: github.com/quickfixgo/quickfix
               │     old     │          new-no-indexbyte          │
               │   sec/op    │   sec/op     vs base               │
ParseMessage-8   695.2n ± 1%   628.2n ± 1%  -9.64% (p=0.000 n=20)

@sylr
Optimize tag value parsing

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
f725b98 
```
goos: darwin
goarch: arm64
pkg: github.com/quickfixgo/quickfix
               │     old     │          new-no-indexbyte          │
               │   sec/op    │   sec/op     vs base               │
ParseMessage-8   695.2n ± 1%   628.2n ± 1%  -9.64% (p=0.000 n=20)
```

Signed-off-by: Sylvain Rabot <[email protected]>
@ackleymi ackleymi merged commit f8a53b0 into quickfixgo:main Aug 9, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sylr @ackleymi