Ignore unknown flags

[mxinden]

Some of the command line flags provided by the libp2p/test-plans/perf/runner are irrelevant to the quic-go/perf implementation, e.g. the --transport flag. Instead of explicitly ignoring those flags, I suggest ignoring all unknown flags. As far as I can tell the flag package does not provide such option, but the go-flags does.

Mind switching to go-flags here @marten-seemann?

[mxinden]

Friendly ping. @marten-seemann any objections?

[marten-seemann]

The problem is that this changes the command line API:

❯ go run cmd/main.go -server-address 127.0.0.1:1234 -run-server=true                                                                  
Usage:
  main

Application Options:
  --run-server        run as server, default: false
  --server-address=   server address, required
  --upload-bytes=     upload bytes
  --download-bytes=   download bytes

Apparently it's now expecting -- instead of -.

[mxinden]

go-flags allows specifying short flags, though they are only allowed to be one character long.

Is this a show-stopper for you @marten-seemann? Is there someone depending on e.g. -server-address being valid?

As far as I can tell it is unix convention for the single hyphen flag to be one character long. See e.g. man ls.

[marten-seemann]

I thought this was the required API for the performance tooling, isn't it?

[mxinden]

Ah, that is the source of the confusion. No, all other implementations use -- instead of -.

[marten-seemann]

Ok, then this is fine. Thanks for clarifying!

[mxinden]

🙏