Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): broken HTTP sender retries #39

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

puzpuzpuz
Copy link
Collaborator

@puzpuzpuz puzpuzpuz commented Jun 27, 2024

Fixes client-side retry errors like this one: http: ContentLength=11977933 with Body length 0.

The HTTP sender now creates a new http.Request instance on each retry attempt to avoid partially consumed request body.

@puzpuzpuz puzpuzpuz added the bug Something isn't working label Jun 27, 2024
@puzpuzpuz puzpuzpuz self-assigned this Jun 27, 2024
@puzpuzpuz puzpuzpuz marked this pull request as ready for review June 27, 2024 09:11
@puzpuzpuz puzpuzpuz merged commit 4776744 into main Jun 27, 2024
3 checks passed
@puzpuzpuz puzpuzpuz deleted the proper-http-retry-fix branch June 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants