Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add May Preview and May GA Api for Analyze Conversations in Cognitive Services Language #1

Closed
wants to merge 211 commits into from
Closed

Conversation

aurghob
Copy link
Collaborator

@aurghob aurghob commented Apr 8, 2024

Data Plane API - Pull Request

Adding May Preview and May GA API for Analyze Conversations API for Cognitive Services Language.
Please note that this change is on top of and dependent on Azure#27392.

Brief overview of changes:

  1. All November Preview API changes carry over to May Preview API (2023-05-15-preview) except for conversational sentiment which is removed.
  2. Conv PII is GA with the GA API (2024-05-01).
  3. Conv Summarization task stays GA.
  4. Note : Custom Conversation summarization stays in preview and not GA.
  5. follow-up tasks aspect used in Conv Summarization is not being GA and stays in upcoming preview. It was present in the last Nov Preview API (2023-11-15-preview).

TODO: Run emitter via https://azure.github.io/typespec-azure/docs/emitters/typespec-autorest/reference/emitter
Note : Cannot run examples at the moment due to Azure/autorest.csharp#4495

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This Change is to migrate the Language.AnalyzeText and Language.Conversations APIs to typespec

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Checks stuck in `queued` state? If the PR CI checks appear to be stuck in `queued` state, please add a comment with contents `/azp run`. This should result in a new comment denoting a `PR validation pipeline` has started and the checks should be updated after few minutes.

fix Azure#27554

Zach-King2 and others added 30 commits June 28, 2023 17:36
* setup

* modified CODEOWNERS

* new changes

* new changes

* new changes

* fixing validation errors
* setup

* modified CODEOWNERS

* new changes

* new changes

* new changes

* fixing validation errors

* adding models

* added models

* resolved comments

* added AADToken

* defined AADToken as model

* added common.tsp

* edited formatting

* fixed syntax

* resolved comments

* removed required property

* changed ErrorResponse to a model

* model updates
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate

* added projectedname decorator to some properties

* edits to models in common.tsp

* edited model properties in main.tsp
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate

* added projectedname decorator to some properties

* edits to models in common.tsp

* edited model properties in main.tsp

* fixed spacing

* updating config

* spacing fix

* modified service-dir path

* removed csharp

* tsp config changes

* removed autorest import

* LuisTargetIntentResult model update

* added csharp emitter

* model change

* removed autorest

* model property change

* modified model property

* useauth change

* capitalized endpoint

* changed endpoint to lowercase

* back to uppercase
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate

* added projectedname decorator to some properties

* edits to models in common.tsp

* edited model properties in main.tsp

* fixed spacing

* updating config

* spacing fix

* modified service-dir path

* removed csharp

* tsp config changes

* removed autorest import

* LuisTargetIntentResult model update

* added csharp emitter

* model change

* removed autorest

* model property change

* modified model property

* useauth change

* capitalized endpoint

* changed endpoint to lowercase

* back to uppercase

* sdk generation fix
…r Analyze Conversations (Azure#24899)

Added 2023-04-01 and 2023-04-15-preview version models to TypeSpec for Analyze Conversations
---------

Co-authored-by: Quentin Robinson <[email protected]>
…ions-typespec.2' into qrobinson/feature-cognitiveserviecs-langueage.AnalyzeText-typespec.1
…ecs-language.conversations-typespec.3' into qrobinson/feature-cognitiveserviecs-langueage.AnalyzeText-typespec.1
* setup

* modified CODEOWNERS

* new changes

* new changes

* new changes

* fixing validation errors
* setup

* modified CODEOWNERS

* new changes

* new changes

* new changes

* fixing validation errors

* adding models

* added models

* resolved comments

* added AADToken

* defined AADToken as model

* added common.tsp

* edited formatting

* fixed syntax

* resolved comments

* removed required property

* changed ErrorResponse to a model

* model updates
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate

* added projectedname decorator to some properties

* edits to models in common.tsp

* edited model properties in main.tsp
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate

* added projectedname decorator to some properties

* edits to models in common.tsp

* edited model properties in main.tsp

* fixed spacing

* updating config

* spacing fix

* modified service-dir path

* removed csharp

* tsp config changes

* removed autorest import

* LuisTargetIntentResult model update

* added csharp emitter

* model change

* removed autorest

* model property change

* modified model property

* useauth change

* capitalized endpoint

* changed endpoint to lowercase

* back to uppercase
* added route

* added examples to path object

* fixed example file paths

* route changes

* removed union

* fixes

* fixes

* fixes

* fixes

* fixed example file paths

* removed example

* updated route

* rebase

* rebase

* rebase

* added examples to path object

* fixed example file paths

* rebase

* edited config

* added comment

* removed import

* added team as codeowners

* removed examples

* added version enum and edited tspconfig

* added doc decorators to enums

* added more doc decorators to enums

* validation fixes

* lint diff fix

* suppressed warnings

* supressed enum warnings and removed '/language' from hostTemplate

* added projectedname decorator to some properties

* edits to models in common.tsp

* edited model properties in main.tsp

* fixed spacing

* updating config

* spacing fix

* modified service-dir path

* removed csharp

* tsp config changes

* removed autorest import

* LuisTargetIntentResult model update

* added csharp emitter

* model change

* removed autorest

* model property change

* modified model property

* useauth change

* capitalized endpoint

* changed endpoint to lowercase

* back to uppercase

* sdk generation fix
bidisha-c and others added 19 commits April 16, 2024 16:17
…xt-typespec.2' of https://github.com/quentinRobinson/azure-rest-api-specs into qrobinson/feature-congnitiveservices-language.AnalyzeText-typespec.2
…xt-typespec.2' of https://github.com/quentinRobinson/azure-rest-api-specs into qrobinson/feature-congnitiveservices-language.AnalyzeText-typespec.2
…xt-typespec.2' of https://github.com/quentinRobinson/azure-rest-api-specs into qrobinson/feature-congnitiveservices-language.AnalyzeText-typespec.2
aurghob pushed a commit that referenced this pull request Apr 23, 2024
* Adds base for updating Microsoft.AppPlatform from version preview/2023-11-01-preview to version 2024-01-01-preview

* Updates readme

* Updates API version in new specs and examples

* add cspell exclusion (Azure#26987)

* Add option for Application Configuration Service refresh interval (Azure#26943)

* add the option for acs refresh interval
* refine description and complete examples

* feat: Add Java 21 (Azure#26946)

* add buildpacks version (Azure#26933)

* Update appplatform.json
* Update BuildServiceBuilder_Get.json
* Update BuildServiceBuilder_List.json
* Update BuildServiceBuilder_CreateOrUpdate.json

* Update language specific readme.md for 2024-01-01-preview api version (Azure#27041)

* Cherry latest stable branch change to preview API version (Azure#27063)

* e94094b

* 4a35b74

* f3e4338

* 4a35b74

* a92c321

* 9a93245

* a693dc6

* fix lint

* fix lint

* add buildpacks version (Azure#27061)

* Update appplatform.json
* Update BuildServiceBuilder_Get.json
* Update BuildServiceBuilder_List.json
* Update BuildServiceBuilder_CreateOrUpdate.json
* Update BuildService_GetSupportedBuildpack.json

* Update readme.md (Azure#27095)

* Short lived app support (Azure#26958)

* Short lived app support
* Rename type to kind

* add cancelled (#1)

* Add testEndpointAuthState to AppResourceProperties (Azure#26938)

* add disable test endpoint auth to AppResourceProperties
* Update Apps_CreateOrUpdate_VNetInjection.json
* Update Apps_CreateOrUpdate.json
* Update Apps_Get.json
* Update Apps_Get_VNetInjection.json
* Update Apps_List.json
* Update Apps_List_VNetInjection.json
* Update Apps_SetActiveDeployments.json
* Update Apps_Update.json
* Update Apps_Update_VNetInjection.json
* use enum for test endpoint auth

* remove api version from readme.python.md

* revert short lived app API (Azure#27196)

* adding version for python sdk temporarily for python sdk generation

---------

Co-authored-by: Jeff <[email protected]>
Co-authored-by: Qingyi Liu <[email protected]>
Co-authored-by: Yuwei Zhou <[email protected]>
Co-authored-by: ninpan-ms <[email protected]>
Co-authored-by: Sandy Cai <[email protected]>
@aurghob aurghob changed the base branch from qrobinson/feature-congnitiveservices-language.AnalyzeText-typespec.2 to main April 23, 2024 22:07
@aurghob aurghob changed the base branch from main to aurghob/maypreviewga April 23, 2024 22:07
@aurghob aurghob changed the base branch from aurghob/maypreviewga to main April 23, 2024 22:07
quentinRobinson pushed a commit that referenced this pull request Jul 8, 2024
…onvmaypreview ga (Azure#28841)

* Add examples and api version for May GA and Preview

* Add Aspect related tsp changes

* Some API version corrections

* Remove Custom Conv Summarization examples from May GA examples

* minor api adjustments for other custom conv summarization attributes

* Add an example and specifications for entity tags (#1)

* compile fixes

* Add examples

* Examples changes

* Changes to remove older preview API version in Analyze conversations

* Fix compile error and add compiled swagger json

* Fix some avocado and prettier check issues

* Fix some more lintdiff and avocado errors

* Correct Readme

* Fix typespec validation

* Address minor documenatation comment

---------

Co-authored-by: Aurgho Bhattacharjee <[email protected]>
Co-authored-by: nithya4 <[email protected]>
@aurghob aurghob closed this by deleting the head repository Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants