Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify annotation handling of layoutCompact #183

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Clarify annotation handling of layoutCompact #183

merged 1 commit into from
Jul 24, 2020

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Jul 21, 2020

Fixes #180.

@sjakobi
Copy link
Collaborator Author

sjakobi commented Jul 21, 2020

@quchen, @georgefst, could you review? :)

@georgefst
Copy link
Contributor

LGTM

1 similar comment
@quchen
Copy link
Owner

quchen commented Jul 24, 2020

LGTM

@sjakobi sjakobi merged commit 3ca2b92 into master Jul 24, 2020
@sjakobi sjakobi deleted the sjakobi/180-layoutCompact branch July 24, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The docs for layoutCompact should say that annotations are stripped.
3 participants
@sjakobi @georgefst @quchen