Compute ribbon width with floor instead of round
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjakobi
changed the title
floor instead of roundfloor instead of round
|
@quchen I'd be interested to know what you think about this! :) |
|
I’m not passionate about ribboning in general. I agree that |
|
Thanks for the feedback @quchen! :) I'll include this in the next major release then. |
sjakobi
force-pushed
the
157-ribbon-width-floor
branch
from
d5aa216
to
6aaa4b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
floorseems like the more appropriate method to handle fractional ribbon widths. E.g. when the ribbon width is 7.5, we don't want to allow a ribbon of 8 columns.Fixes #157.