Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry all Errors in Case of Get Request #309

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Retry all Errors in Case of Get Request #309

merged 1 commit into from
Feb 28, 2020

Conversation

chattarajoy
Copy link
Member

@chattarajoy chattarajoy commented Feb 28, 2020 •
edited
Loading

Added the following Changes:

  1. Rename MyAdapter to RequestAdapter
  2. Revert last change of checking non-JSON response first
  3. Retry on all error status codes for GET requests

@chattarajoy chattarajoy requested a review from sunasra February 28, 2020 04:59
@chattarajoy chattarajoy merged commit f820742 into qubole:unreleased Feb 28, 2020
chattarajoy added a commit to chattarajoy/qds-sdk-py that referenced this pull request Feb 28, 2020
@chattarajoy
Retry all Errors in Case of Get Request (qubole#309)
96d40bf
chattarajoy added a commit that referenced this pull request Mar 2, 2020
@chattarajoy
Refactor Connection Adapter name (#309)
8a95947
chattarajoy added a commit that referenced this pull request Mar 2, 2020
@chattarajoy
Refactor Connection Adapter name (#309)
caec9b1
chattarajoy added a commit that referenced this pull request Mar 18, 2020
@chattarajoy
Refactor Connection Adapter name (#309)
b44b2a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunasra sunasra sunasra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chattarajoy @sunasra