Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception instead of "pass" to avoid silently skipping of write #205

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Add exception instead of "pass" to avoid silently skipping of write #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions qds_sdk/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,8 +1261,7 @@ def _read_iteratively(key_instance, fp, delim):
elif isinstance(fp, io.BufferedIOBase) or isinstance(fp, io.RawIOBase):
fp.write(data.decode('utf8').replace(chr(1), delim).encode('utf8'))
else:
# Can this happen? Don't know what's the right thing to do in this case.
pass
raise ValueError('Only subclasses of io.TextIOBase or io.BufferedIOBase supported')
except StopIteration:
# Stream closes itself when the exception is raised
return
Expand Down