Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add helper text for input (PROJQUAY-7442) #3015

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

Sunandadadi
Copy link
Contributor

Screenshot 2024-07-10 at 1 43 36 PM

Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, otherwise lgtm!

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.44%. Comparing base (0cdd254) to head (ddb925a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3015      +/-   ##
==========================================
+ Coverage   70.43%   70.44%   +0.01%     
==========================================
  Files         440      440              
  Lines       41484    41516      +32     
  Branches     5440     5451      +11     
==========================================
+ Hits        29218    29248      +30     
- Misses      10548    10550       +2     
  Partials     1718     1718              
Flag Coverage Δ
unit 70.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harishsurf
harishsurf previously approved these changes Jul 10, 2024
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Sunandadadi Sunandadadi merged commit 1bff53e into master Jul 11, 2024
29 checks passed
@Sunandadadi
Copy link
Contributor Author

/cherrypick redhat-3.12

@openshift-cherrypick-robot

@Sunandadadi: new pull request created: #3017

In response to this:

/cherrypick redhat-3.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants