Enable runtime fetcher disable/enable #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a configuration section to config.yaml which allows users to enable/disable each fetcher at runtime. Signed-off-by: Avi Miller <[email protected]>
Quentin-M
added
area/usability
|
Thanks, I really like the idea, thanks for your contribution! |
|
The code looks really good. @Quentin-M should we ship this after 2.0 for as a part of it? We're already breaking the config. |
|
The existing config (unmodified) should allow Clair to run without modification. The config changes can be added to disable fetchers, but without the config, all fetchers should work (as before). |
|
This sounds good to me. Let's have them all default to on, but can be disabled. |
jzelinskie
added
reviewed/needs rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #221
This adds a configuration section to config.yaml which allows users
to enable/disable each fetcher at runtime.
I used the same mechanism being used by the notifications so that future fetchers can add additional configuration items without too much work.
Signed-off-by: Avi Miller [email protected]