Dev environment changes #1397
Merged
Dev environment changes #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
|
containers/podman#11966 is released in podman 3.4.1, so circling back to check on quay. |
hdonnay
force-pushed
the
debug/PROJQUAY-2152
branch
6 times, most recently
from
44205d2 to
eab29a7
Compare
hdonnay
force-pushed
the
debug/PROJQUAY-2152
branch
from
eab29a7 to
600886d
Compare
crozzy
previously approved these changes
Nov 4, 2021
| ``` | ||
|
|
||
| After the local development environment successfully starts, the following infrastructure is available to you: | ||
|
|
||
| ``` | ||
| localhost:8080 --- Quay (single node, local storage) |
There was a problem hiding this comment.
Definitely an improvement here, although can we find somewhere for the credentials to avoid browsing / execing around for the defaults?
| $(docker-compose) --profile $* up -d | ||
|
|
||
| local-dev-quay: local-dev/clair/quay.yaml vendor | ||
| CLAIR_CONFIG=$(<F) $(docker-compose) --profile quay up -d |
There was a problem hiding this comment.
you think cleaning up the local-dev/clair/quay.yaml file here is a bit overreaching?
There was a problem hiding this comment.
What do you mean "cleaning up?" It needs to exist while things are running, and needs to be slightly different from the standard config. It being a proper target and dependency at least makes sure it gets updated as the standard config changes.
hdonnay
force-pushed
the
debug/PROJQUAY-2152
branch
5 times, most recently
from
d5ef9c1 to
22d723b
Compare
Signed-off-by: Hank Donnay <[email protected]>
This script emulates a webhook receiver by retrieving every notification and then deleting it. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
This means the docker socket doesn't need to be mounted into the traefik container, at the cost/advantage of putting the config in separate files instead of container labels. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
This makes the entire docker-compose file much easier to follow and modify, IMO. It also has the notable benefit of `docker-compose up` just working. Signed-off-by: Hank Donnay <[email protected]>
This removes the explicit `docker-compose` usage in favor of using the profiles. It also changes the documentation target to be an actual target. Signed-off-by: Hank Donnay <[email protected]>
This is to work around Quay's inability to handle split-view DNS and port-forwards. Using the API over localhost means clair can't talk to quay, and using the container name means the host can't talk to quay over the port forward. The solution I hit on is to just have a waiting container with skopeo. The documentation is updated to not recommend spinning up quay by default, and to mention how to use this odd container arrangement. Signed-off-by: Hank Donnay <[email protected]>
This provides a container that speaks both STOMP and AMQP. Signed-off-by: Hank Donnay <[email protected]>
hdonnay
force-pushed
the
debug/PROJQUAY-2152
branch
from
22d723b to
3c2ad90
Compare
crozzy
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating PROJQUAY-2152, I made a lot of changes.
This is both the jig I built to verify the notifier, and the changes to the dev environment to be less dependent on Docker specifically and utilize
docker-compose's native profile support.