-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align properties of websmith CLI and webpack-loader options #53
Labels
enhancement
New feature or request
Comments
jwloka
added a commit
that referenced
this issue
Jan 25, 2025
* Remove unused default values * Handle targets in compiler and webpack still differently fixes #53
jwloka
added a commit
that referenced
this issue
Jan 25, 2025
and PluginOptions to WebsmithLoaderConfig fixes #53
jwloka
added a commit
that referenced
this issue
Jan 26, 2025
jwloka
added a commit
that referenced
this issue
Jan 26, 2025
This change aligns the CLI with standard TSC. fixes #53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Suggestion
websmith in the current version uses different names, value types and even structure in configuration properties. We should align the properties in
CompilerOptions
andCompilationConfig
with the properties inPluginArguments
to use similar if not the same naming and structure.✅ Viability Checklist
My suggestion meets these guidelines:
Existing addons wouldn't be affected by the change, but existing configuration need be adjusted
⭐ Suggestion
CompilationConfig#configFilePath
toCompilerOptions#configFile
.PluginArguments#addons
tostring[]
PluginArguments#config
toPluginArguments#configFile
PluginArguments#config: CompilationConfig
PluginArguments#tsConfig: tsCompilerOptions
PluginArguments#targets
tostring[]
PluginArguments
toWebsmithLoaderOptions
PluginOptions
toWebsmithLoaderConfig
All added and changed properties should remain optional.
📃 Motivating Example
After this refactoring the configurations would almost look the same:
The text was updated successfully, but these errors were encountered: