analyzer: use sync.Pool to re-use ruleguard runner state #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some test runs, this allows to allocate ~10 state objects instead of ~3000 without such pool. Allocating a runner state is an expensive operation, we want to re-use as much state as possible to make ruleguard faster. This patch should be used as an example of how ruleguard can be integrated into `go/analysis` framework while still having a reusable state between the engine runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some test runs, this allows to allocate ~10 state objects instead of ~3000 without such pool.
Allocating a runner state is an expensive operation, we want to re-use as much state as possible to make ruleguard faster.
This patch should be used as an example of how ruleguard can be integrated into
go/analysisframework while still having a reusable state between the engine runs.