Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate loader rule matching in webpack config #49

Closed
wants to merge 1 commit into from

Conversation

rfox12
Copy link

@rfox12 rfox12 commented Nov 4, 2021

Probably not an issue, but the inspecting the webpack config you can see the duplication of tags:

      {
        loader: 'vue-loader',
        options: {
          compilerOptions: {},
          transformAssetUrls: {
            base: null,
            includeAbsolute: false,
            tags: {
              video: [
                'src',
                'poster',
                'src',
                'poster',
                [length]: 4
              ],
              source: [
                'src',
                'src',
                [length]: 2
              ],
              img: [
                'src',
                'src',
                [length]: 2
              ],
...

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Probably not an issue, but the inspecting the webpack config you can see the duplication of tags:
```
      {
        loader: 'vue-loader',
        options: {
          compilerOptions: {},
          transformAssetUrls: {
            base: null,
            includeAbsolute: false,
            tags: {
              video: [
                'src',
                'poster',
                'src',
                'poster',
                [length]: 4
              ],
              source: [
                'src',
                'src',
                [length]: 2
              ],
              img: [
                'src',
                'src',
                [length]: 2
              ],
...
```
rstoenescu added a commit that referenced this pull request Nov 5, 2021
@rstoenescu
Copy link
Member

Ah, damn. I thought this was a github ticket, not a PR :(
Exhaustion at its best. Sorry for not merging your PR :(

@rstoenescu rstoenescu closed this Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants