Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: spelling #17697

Merged
merged 1 commit into from
Dec 11, 2024
Merged

docs: spelling #17697

merged 1 commit into from
Dec 11, 2024

Conversation

smakinson
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Copy link

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/Notify.json b/./pr-build/api/Notify.json
index 7f0a443..847f3be 100644
--- a/./current-build/api/Notify.json
+++ b/./pr-build/api/Notify.json
@@ -283,7 +283,7 @@
           },
           "...": {
             "type": "Any",
-            "desc": "Any other QBtn prop expect 'onClick' (use 'handler' instead, only possible with UI config)",
+            "desc": "Any other QBtn prop except 'onClick' (use 'handler' instead, only possible with UI config)",
             "examples": [
               "label: 'Learn more'",
               "color: 'primary'"
@@ -608,7 +608,7 @@
                 },
                 "...": {
                   "type": "Any",
-                  "desc": "Any other QBtn prop expect 'onClick' (use 'handler' instead)",
+                  "desc": "Any other QBtn prop except 'onClick' (use 'handler' instead)",
                   "examples": [
                     "label: 'Learn more'",
                     "color: 'primary'"

Types

📜 No changes detected.

@rstoenescu rstoenescu merged commit 3d7ab21 into quasarframework:dev Dec 11, 2024
1 check passed
@rstoenescu
Copy link
Member

Thanks for catching this and providing a PR!

@smakinson smakinson deleted the patch-2 branch December 12, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants