-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@quasar/app uses undeclared dependency "pretty-error" #8459
Comments
@pdanpdan what info do you need |
here it's being used:
and here is the package.json that doesn't have the dependency: |
The version of app :) but now can be inferred from the branch. |
it's yarn with version codename berry, I believe it's beta of v2, but I'm not 100% sure. |
I didn't! But the fact that that package is not in the package.json I felt was worth reporting regardless. |
This is a non-issue. The html-webpack-plugin already includes it. By now you would've noticed that if this was an issue it would've surfaced ages ago on any CLI errors being printed out :) For completeness though, I'll add it. |
That's not how that works, if you're interested see https://yarnpkg.com/advanced/rulebook#packages-should-only-ever-require-what-they-formally-list-in-their-dependencies for details on dependency hoisting |
This will become an obsolete thing anyway. Working on the Webpack 5 upgrade and I'm at the stage of redesigning how all errors and warnings are caught and displayed. This includes explicitly adding pretty-error as a direct dep of q/app. |
The text was updated successfully, but these errors were encountered: