Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg<type>Grade removed. Use svg<type>Star. Used in iconsets as "rating". #17640

Closed
hawkeye64 opened this issue Nov 14, 2024 Discussed in #17632 · 5 comments
Closed

svg<type>Grade removed. Use svg<type>Star. Used in iconsets as "rating". #17640

hawkeye64 opened this issue Nov 14, 2024 Discussed in #17632 · 5 comments
Assignees

Comments

@hawkeye64
Copy link
Member

Discussed in #17632

Originally posted by yaourt November 10, 2024
I'm trying to change the iconSet in quasarconfig to 'svg-material-symbols-outlined' but then it gives me the following when doing a quasar dev or quasar build:

node_modules/.pnpm/[email protected]/node_modules/quasar/icon-set/svg-material-symbols-outlined.js:64:2: ERROR: No matching export in "node_modules/.pnpm/@[email protected]/node_modules/@quasar/extras/material-symbols-outlined/index.mjs" for import "symOutlinedGrade"

Is there a mistake on my side ?
or is this an issue with the icon named grade in material-icons that does not exist anymore in material-symbols-* ?

@hawkeye64 hawkeye64 self-assigned this Nov 14, 2024
@hawkeye64 hawkeye64 changed the title Changing the iconSet to svg-material-symbols-outlined produces an error, icon named grade does not exist anymore ? svg<type>Grade removed. Use svg<type>Star. Used in iconsets as "rating". Nov 14, 2024
hawkeye64 added a commit that referenced this issue Nov 14, 2024
@hawkeye64
Copy link
Member Author

Will be resolved in the next release.

@yaourt
Copy link

yaourt commented Nov 17, 2024

Thanks for this update 👍

But I'm wondering if quasar-extras needs also an update.

I'm trying to not use material-design-icons font at all, and instead use the svg-material-symbols-outlined iconSet.

This gives me:

node_modules/.pnpm/[email protected]/node_modules/quasar/icon-set/svg-material-symbols-outlined.js (64:2): "symOutlinedGrade" is not exported by "node_modules/.pnpm/@[email protected]/node_modules/@quasar/extras/material-symbols-outlined/index.mjs", imported by "node_modules/.pnpm/[email protected]/node_modules/quasar/icon-set/svg-material-symbols-outlined.js".

@yaourt
Copy link

yaourt commented Nov 17, 2024

Oh, in fact there is no change in the dev branch.

There is a warning at the top of the modified files saying that those files are generated, the edit should have been in material-symbols-.js (and not in their svg- counterparts) !

@rstoenescu
Copy link
Member

Will be fixed in Quasar v2.17.4

@hawkeye64
Copy link
Member Author

Will be fixed in Quasar v2.17.4

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants