chore(QTabs): shorter algorithm for onClick

quasarframework · Sep 30, 2022 · 5221ac1 · 5221ac1
1 parent f5671d5
commit 5221ac1
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/ui/src/components/tabs/QTab.js b/ui/src/components/tabs/QTab.js
@@ -152,20 +152,17 @@ export default Vue.extend({
           // if requiring to go to another route, then we
           // let the QTabs route watcher do its job,
           // otherwise directly select this
+          let failed
           const reqId = sameInternalRoute === true
             ? (this.$tabs.avoidRouteWatcher = uid())
             : null
 
           return this.$router[replace === true ? 'replace' : 'push'](resolvedLink.location)
-            .then(() => {
-              if (reqId === this.$tabs.avoidRouteWatcher) {
-                this.$tabs.__updateModel({ name: this.name })
-              }
-            })
-            .catch(() => {})
+            .catch(() => { failed = true })
             .finally(() => {
               if (reqId === this.$tabs.avoidRouteWatcher) {
                 this.$tabs.avoidRouteWatcher = false
+                failed !== true && this.$tabs.__updateModel({ name: this.name })
               }
             })
         }