Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QMarkdown extension missing dependencies #277

Closed
auriorx opened this issue Sep 26, 2021 · 2 comments
Closed

QMarkdown extension missing dependencies #277

auriorx opened this issue Sep 26, 2021 · 2 comments

Comments

@auriorx
Copy link

auriorx commented Sep 26, 2021

Describe the bug
Adding the QMarkdown@next extension and running quasar dev leads to missing markdown-it components.

To Reproduce
Steps to reproduce the behavior:

  1. Run quasar upgrade -i
  2. Run quasar ext add @quasar/qmarkdown@next
  3. Run quasar dev
  4. Returns errors for markdown-it-* subcomponents like: UnhandledPromiseRejectionWarning: Error: Cannot find module 'markdown-it-footnote

Expected behavior
I would expect quasar dev to work after running quasar ext add @quasar/qmarkdown

Desktop:

  • OS: Windows 11
  • Browser: -
  • Version: -

Additional context
Full error example:

(node:26208) UnhandledPromiseRejectionWarning:   Error: Cannot find module 'markdown-it-footnote'
  Require stack:
  - {path_to_project}\node_modules\@quasar\quasar-app-extension-qmarkdown\src\markdown.js
  - {path_to_project}\node_modules\@quasar\quasar-app-extension-qmarkdown\src\index.js
  - {path_to_project}\node_modules\@quasar\app\lib\app-extension\Extension.js
  - {path_to_project}\node_modules\@quasar\app\lib\app-extension\extensions-runner.js
  - {path_to_project}\node_modules\@quasar\app\lib\quasar-conf-file.js
  - {path_to_project}\node_modules\@quasar\app\bin\quasar-dev
  - {path_to_project}\node_modules\@quasar\app\bin\quasar
  - C:\Users\{user}\AppData\Roaming\npm\node_modules\@quasar\cli\bin\quasar

  - loader.js:889 Function.Module._resolveFilename
    internal/modules/cjs/loader.js:889:15

  - loader.js:745 Function.Module._load
    internal/modules/cjs/loader.js:745:27

  - loader.js:961 Module.require
    internal/modules/cjs/loader.js:961:19

  - helpers.js:92 require
    internal/modules/cjs/helpers.js:92:18

  - markdown.js:7 Object.<anonymous>
    [flink-frontend-temp]/[@quasar]/quasar-app-extension-qmarkdown/src/markdown.js:7:18

  - loader.js:1072 Module._compile
    internal/modules/cjs/loader.js:1072:14

  - loader.js:1101 Object.Module._extensions..js
    internal/modules/cjs/loader.js:1101:10

  - loader.js:937 Module.load
    internal/modules/cjs/loader.js:937:32

  - loader.js:778 Function.Module._load
    internal/modules/cjs/loader.js:778:12

  - loader.js:961 Module.require
    internal/modules/cjs/loader.js:961:19


(Use `node --trace-warnings ...` to show where the warning was created)
(node:26208) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:26208) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Workaround
I've manually added the following packages to make it work:

yarn add markdown-it-emoji
yarn add markdown-it-sub
yarn add markdown-it-sup
yarn add markdown-it-footnote
yarn add markdown-it-deflist
yarn add markdown-it-abbr
yarn add markdown-it-ins
yarn add markdown-it-mark
yarn add markdown-it-task-lists

Any user also experiencing this issue could use the code above to manually insert the missing packages quickly.

@hawkeye64
Copy link
Member

Please see release notes, specifically breaking changes, in the last release: https://github.com/quasarframework/quasar-ui-qmarkdown/releases/tag/v2.0.0-alpha.7

It looks like the app-extension itself was missed as it converts markdown at build time for imported *.md files.

@hawkeye64 hawkeye64 changed the title QMarkdown extension misses dependencies QMarkdown extension missing dependencies Sep 28, 2021
@hawkeye64
Copy link
Member

This is fixed in v2.0.0-alpha.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants