build: Rework build and upgrade dependencies #3
Conversation
| @@ -120,14 +215,6 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
There was a problem hiding this comment.
why are we removing this?
There was a problem hiding this comment.
The declaration isn't needed, unit tests are run by default using this plugin.
docker run --rm -v $(pwd):/workspace -w /workspace maven:3-eclipse-temurin-17 mvn clean package
[INFO] Compiling 2 source files to /workspace/target/test-classes
[INFO]
[INFO] --- surefire:3.0.0:test (default-test) @ akash-java ---
There was a problem hiding this comment.
But this way we can define a version. I think we should keep it.
| <version>${surefire.verion}</version> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-failsafe-plugin</artifactId> |
There was a problem hiding this comment.
why are we removing failsafe?
There was a problem hiding this comment.
Failsafe is usually used to run integration tests (tests named after these patterns https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html#inclusions).
This declaration isn't needed as long as there are no integration tests.
| @@ -4,9 +4,9 @@ | |||
| <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern> | |||
| </encoder> | |||
| </appender> | |||
| <logger name="cloud.quasarch" level="DEBUG" /> | |||
There was a problem hiding this comment.
Having this logger is handy for test debugging purposes, therefore i dont see why we should remove it
There was a problem hiding this comment.
I think it makes running tests a lot more verbose/noisy.
I can still restore it if you want to maintain this level.
There was a problem hiding this comment.
I guess it's good to have since this makes it clear for developers where and how can they tweak log levels for tests and that they can do it package level also.
| @@ -120,14 +215,6 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
There was a problem hiding this comment.
But this way we can define a version. I think we should keep it.
| <version>${surefire.verion}</version> | ||
| </plugin> | ||
| <plugin> | ||
| <artifactId>maven-failsafe-plugin</artifactId> |
| @@ -4,9 +4,9 @@ | |||
| <pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n</pattern> | |||
| </encoder> | |||
| </appender> | |||
| <logger name="cloud.quasarch" level="DEBUG" /> | |||
There was a problem hiding this comment.
I guess it's good to have since this makes it clear for developers where and how can they tweak log levels for tests and that they can do it package level also.
|
I have submitted the requested changes. In addition, could we consider moving the examples module to its own project? Thanks |
Rework build and upgrade dependencies
Could we consider moving the
examplesmodule to its own project?