Feature/fontawesome6 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh. This is interesting, because I did test your previous change and I saw the x-twitter icon. Is there a test that could have found the difference? |
|
I actually don’t know. I was working with the file from fortawesome/fontawesome. And I guess in some of my work I deleted too much, since the file from yesterday has a couple hundred files less.
… Am 23.09.2023 um 17:52 schrieb Carlos Scheidegger ***@***.***>:
Huh. This is interesting, because I did test your previous change and I saw the x-twitter icon.
Is there a test that could have found the difference?
—
Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARI2FFJEFFL2IZ3WE5AO3H3X34AVFANCNFSM6AAAAAA5ECINRU>.
You are receiving this because you authored the thread.
|
|
Ok. This is unfortunate, but we'll merge. I might contact you again should someone else find a bug :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @cscheid ,
I just recognized that I got lost in my files and uploaded the wrong
all.css(that does no included all icons). I corrected it and here is the correct file.