Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move fix to #10567 into website postprocessor #11639

Merged
merged 4 commits into from
Dec 10, 2024
Merged

move fix to #10567 into website postprocessor #11639

merged 4 commits into from
Dec 10, 2024

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Dec 9, 2024

Fixes #11596

This PR does the canonicalizeTitlePostprocessor() into website post processor only which avoid any undesired DOM modification on non website project.

I think we should look into canonicalizeTitlePostprocessor() because it does think for website without checking some assumption

  • it fixes breadcrumbs that only are done in bootstrap format. So possibly the fix should be done in websiteNavigationExtras() which applies only in bootstrap
  • It does try to create a title block and move the title into it, but it does not really do it considering the check on the title. Also it used classes (like quarto-title-banner) that are only used in some specific situation (in the example when title-block-banner is set).

I'll suggest we look in all that more closely for 1.7 and adapt the fix for #10567 in a more generic way (make h1 and no title equivalent to title).

@cderv
Copy link
Collaborator Author

cderv commented Dec 9, 2024

Changelog done in 1.6 for regression fix through

The change for the regression have been simplified

@cderv cderv requested a review from cscheid December 9, 2024 19:52
@cderv
Copy link
Collaborator Author

cderv commented Dec 10, 2024

Let's merge so that pkgdown problem can be solved

@cderv cderv merged commit 6de400b into main Dec 10, 2024
47 checks passed
@cderv cderv deleted the bugfix/issue-11596 branch December 10, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New title canonicalization for h1 is breaking custom rendering (using custom template and no boostrap)
2 participants