move fix to #10567 into website postprocessor #11639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11596
This PR does the
canonicalizeTitlePostprocessor()
into website post processor only which avoid any undesired DOM modification on non website project.I think we should look into
canonicalizeTitlePostprocessor()
because it does think for website without checking some assumptionwebsiteNavigationExtras()
which applies only in bootstrapquarto-title-banner
) that are only used in some specific situation (in the example whentitle-block-banner
is set).I'll suggest we look in all that more closely for 1.7 and adapt the fix for #10567 in a more generic way (make h1 and no title equivalent to title).