General lua improvements #11526
General lua improvements #11526
Conversation
tarleb
force-pushed
the
general-lua-improvements
branch
6 times, most recently
from
fe712ce to
2d7ef41
Compare
| @@ -1,6 +1,10 @@ | |||
| -- _utils.lua | |||
| -- Copyright (C) 2020-2022 Posit Software, PBC | |||
|
|
|||
| --- The pandoc module. Imported to avoid 'no such variable' | |||
| --- warnings in some editors. | |||
| local pandoc = require 'pandoc' | |||
There was a problem hiding this comment.
We should be careful with require() because of https://github.com/quarto-dev/quarto-cli/blob/main/src/resources/pandoc/datadir/init.lua#L1403
I'm not sure I want to add it to this PR...
tarleb
force-pushed
the
general-lua-improvements
branch
from
2d7ef41 to
4274ec0
Compare
|
Great, thanks! We can talk about |
|
One final thing. |
|
Oh, in that case we might also want to redefine that function to be more robust. Also maybe it should only check whether there is any |
|
I'm wary of overdesigning it without a concrete reason to. "More robust" isn't as actionable as "robust with respect to xyz" - what scenario do you have in mind? |
|
No, you're right. The suggested alternative wouldn't even work. I think the original version is fine. |
tarleb
force-pushed
the
general-lua-improvements
branch
from
4274ec0 to
4a329c7
Compare
tarleb
force-pushed
the
general-lua-improvements
branch
from
4a329c7 to
d4b084d
Compare
This behaves mostly like the built-in `assert`, but respects the general Quarto scaffolding.
This also fixes unwanted behavior of `as_blocks`, which would treat a list of Inline elements as a list of singleton Plain elements, leading to bad results.
tarleb
force-pushed
the
general-lua-improvements
branch
from
d4b084d to
a347bc1
Compare
|
Should be good to merge now. |
Description
Improve some general Lua functions.