respect explicitely disabled searchbox in navbar #11339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same fix as for sidebar in 0ba4ad1
Running a render with profile is tricky as it needs to be done using environment variable, which is tricky in async tests. So probably not enough
It does not currently work because setting env var for a test is not safe as several Deno.test() can conflict with one another setup and teardown. Environment is not isolated between tests. So use two duplicated projects with different config for the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as for sidebar in 0ba4ad1Welcome to the quarto GitHub repo!
fixes #9905
About tests changes
I wanted to use profile to avoid file duplication, but after a few tries, I can make it work.
It seems setting env var in setup and teardown is not safe when running several tests one after the other in same file. There are conflict in state due to async function use in
testQuartoCmdI could not make this work as I wanted to make the test pass. 🤔 Probably missing something as I would have expected
to not conflict with each other. I did not find safe way to set env var before test, and unset after in this case.
Anyhow, for another time