Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update to Pandoc 3.4 #10840

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Chore: Update to Pandoc 3.4 #10840

merged 5 commits into from
Sep 24, 2024

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Sep 19, 2024

No description provided.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where you are at on the PR, but as it is not a draft PR I figured I would share feedback anyway to be sure we catch every update before merge

I did comment about LaTeX template update for filling partials.

This is the same for typst template update, though it is less straightforward to update from pandoc's template update to splitting in partials, so I did not commented with the match. However, it needs to be done before merging.

Long term, this is an update process we probably need to make smoother (like with a diff app to quickly show difference, or working with git patches -- just some ideas I have in mind)

Hope it helps

@cscheid
Copy link
Collaborator Author

cscheid commented Sep 24, 2024

This is the same for typst template update, though it is less straightforward to update from pandoc's template update to splitting in partials, so I did not commented with the match.

However, it needs to be done before merging.

Yup, I'm aware.

@cscheid cscheid merged commit 6b363d9 into main Sep 24, 2024
47 checks passed
@cscheid cscheid deleted the chore/1.6-pandoc-update branch September 24, 2024 21:41
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few question since it is merged but I thought we would need to to more.

Also I just remember that our template for quarto create are currently not in sync but we may want to keep them updated
They are in :https://github.com/quarto-dev/quarto-cli/blob/8472625b55cf38ff2246bb65c3e6d70f355dab61/src/resources/create/extensions/

Comment on lines +8 to +10
$if(subtitle)$
subtitle: [$subtitle$],
$endif$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this addition means we need to add its equivalent in #let article() ?

title: none,
title-font: none,
authors: none,

Also subtitle is not used as no processing is currently done with it. See other comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants