-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update to Pandoc 3.4 #10840
Chore: Update to Pandoc 3.4 #10840
Conversation
b0b46bb
to
dd6717f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure where you are at on the PR, but as it is not a draft PR I figured I would share feedback anyway to be sure we catch every update before merge
I did comment about LaTeX template update for filling partials.
This is the same for typst template update, though it is less straightforward to update from pandoc's template update to splitting in partials, so I did not commented with the match. However, it needs to be done before merging.
Long term, this is an update process we probably need to make smoother (like with a diff app to quickly show difference, or working with git patches -- just some ideas I have in mind)
Hope it helps
Yup, I'm aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few question since it is merged but I thought we would need to to more.
Also I just remember that our template for quarto create
are currently not in sync but we may want to keep them updated
They are in :https://github.com/quarto-dev/quarto-cli/blob/8472625b55cf38ff2246bb65c3e6d70f355dab61/src/resources/create/extensions/
$if(subtitle)$ | ||
subtitle: [$subtitle$], | ||
$endif$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this addition means we need to add its equivalent in #let article()
?
title: none, | |
title-font: none, | |
authors: none, |
Also subtitle
is not used as no processing is currently done with it. See other comment.
No description provided.