[revealjs] Improve footer handling #10695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it contains slide-logo and footer default moved around by quarto-support revealjs plugin
slide-logo and footer are moved from there.
useful when default footer is set, but a slide would be better without one
e.g
```markdown
---
title: footers
format:
revealjs:
footer: "Default footer"
---
## Slide with footer
Content
## Slide with no footer {footer="false"}
Content
```
5 tasks
`slidechanged` event is not called on first slide. So `ready` event is necessary to add footer to first slide.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles some improvements for footers.
It moves
div.quarto-auto-generated-contentoutside of slides to prevent any further problem. This is a follow up on revealjs: don't remove content from hidden slide that was added by quarto itself #6801.This div contains
.slide-logoelement and.footer-defaultmoved around by quarto-support revealjs plugin when presentation is loaded in browser.It adds in the pluggin a cleaning step to remove
.quarto-auto-generated-contentas it should be empty and not more useful after footer and slide logo have been moved. Also a follow up on revealjs: don't remove content from hidden slide that was added by quarto itself #6801.It implements a new feature to close [FR] Add a
.no-footerclass to add on revealjs slide to hide a globally defined footer #9558. It is possible to prevent default footer to show on slide by usingfooter='false'as attribute on slide header. If a custom footer is defined in the slide using::: {.footer}then the attribute won't apply.It also closes [FR] Ability to hide footer on specific slides including title-slide #1445 by making sure first loaded slide is correctly configured with custom footer. It needs to be done with
readyevent, and not justslidechangedevent.Side notes
.quarto-auto-generated-contentan ID instead of a class. So that we can targetdiv#quarto-auto-generated-contentand make clear there should be only a single structure like this in our code. I figured it could be too much if anyone is unfortunately using our internal DOM structure before processing.