-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"attempt to index a nil value (field 'caption_long')" error thrown when trying to preview a page with both a lightbox image and an embedded scanpy figure #10196
Comments
Thanks for the report. Is it ok if we use your repo as a regression test? |
Yes, absolutely. I just added the MIT license to the repo. |
Ok. I have a fix already, PR coming up soon. |
Sounds good! No rush, because I'm testing this across our entire repo, so I want to see if there are others that fail for a similar reason. |
Just for the record, this is a downstream consequence of the Pandoc fix that changed how accessing some pandoc AST nodes would cause (our internal record) |
Closes #28 **IMPORTANT** Currently there is a [bug in the stable release of Quarto](quarto-dev/quarto-cli#10196) which prevents rendering of the missing data figures. It is fixed in development version [`v1.6.1`](https://github.com/quarto-dev/quarto-cli/releases/tag/v1.6.1) (currently available as pre-release, so if things don't render upgrade to this version). + Uses the [mice](https://amices.org/mice/index.html) package to summarise missing data graphically and undertake three different methods of multiple imputation. Functions are defined to aid with the plotting of imputed data for comparison to the original dataset. Notes on tasks that could be done to augment this such as tabulation. This is via the `sections/_interpolation.qmd` file. Includes citation for the mice R package. + Moves data dictionary to Appendix. + Tidies up tables adding missing captions and removing `print()` + Moves tables to [panel-tabset](https://quarto.org/docs/interactive/layout.html#tabset-panel) as document was getting long and cluttered. This makes it shorter and easier to navigate. Used for plots that summarise imputation. + Introduces caching to the document so that computationally expensive sections of code are not re-run on every render. + Some house keeping wrapping lines to 120 characters. + Moves summary of missing data patterns to `sections/_missing.qmd`. + Removes `dark_theme_minimal()` from plot of final lasso. + Tidies up `sections/_logistic.qmd` to explicitly use `family = binomial(link = "logit")` (**NB** Previous work ensured the `train` data frame is used in all logistic regression rather the raw `df` which includes individuals with missing `final_pathology`).
Closes #28 **IMPORTANT** Currently there is a [bug in the stable release of Quarto](quarto-dev/quarto-cli#10196) which prevents rendering of the missing data figures. It is fixed in development version [`v1.6.1`](https://github.com/quarto-dev/quarto-cli/releases/tag/v1.6.1) (currently available as pre-release, so if things don't render upgrade to this version). + Uses the [mice](https://amices.org/mice/index.html) package to summarise missing data graphically and undertake three different methods of multiple imputation. Functions are defined to aid with the plotting of imputed data for comparison to the original dataset. Notes on tasks that could be done to augment this such as tabulation. This is via the `sections/_interpolation.qmd` file. Includes citation for the mice R package. + Moves data dictionary to Appendix. + Tidies up tables adding missing captions and removing `print()` + Moves tables to [panel-tabset](https://quarto.org/docs/interactive/layout.html#tabset-panel) as document was getting long and cluttered. This makes it shorter and easier to navigate. Used for plots that summarise imputation. + Introduces caching to the document so that computationally expensive sections of code are not re-run on every render. + Some house keeping wrapping lines to 120 characters. + Moves summary of missing data patterns to `sections/_missing.qmd`. + Removes `dark_theme_minimal()` from plot of final lasso. + Tidies up `sections/_logistic.qmd` to explicitly use `family = binomial(link = "logit")` (**NB** Previous work ensured the `train` data frame is used in all logistic regression rather the raw `df` which includes individuals with missing `final_pathology`).
Bug description
We have a documentation page that has both images using the standard Quarto syntax with the
.lightbox
class and an embedded Jupyter notebook cell containing a scanpy plot. In 1.4.557, Quarto was able to handle both at the same time. In 1.5.52, we now face an error.If I disable the
.lightbox
class on all images on the page, it builds successfully. Also, if I delete theembed
cell pointing to the scanpy plot, it builds successfully. The presence of both causes an error.I've instructed my team not to use 1.5.52 until this issue is resolved, and the steps to downgrade are simple enough. This is also reproducible on 1.6.0.
Steps to reproduce
Using Quarto 1.5.52:
Expected behavior
The page renders correctly and shows both a royalty-free lightbox image of a cat and a scanpy scatter plot.
Actual behavior
The following error is thrown:
Your environment
Quarto check output
Quarto 1.5.52
[✓] Checking versions of quarto binary dependencies...
Pandoc version 3.2.0: OK
Dart Sass version 1.70.0: OK
Deno version 1.41.0: OK
Typst version 0.11.0: OK
[✓] Checking versions of quarto dependencies......OK
[✓] Checking Quarto installation......OK
Version: 1.5.52
Path: /Applications/quarto/bin
[✓] Checking tools....................OK
TinyTeX: (not installed)
Chromium: (not installed)
[✓] Checking LaTeX....................OK
Tex: (not detected)
[✓] Checking basic markdown render....OK
[✓] Checking Python 3 installation....OK
Version: 3.12.4 (Conda)
Path: /Users/nickv/miniforge3/envs/index-nil-value-caption-long-lightbox-bug/bin/python
Jupyter: 5.7.2
Kernels: ir, python3
[✓] Checking Jupyter engine render....OK
[✓] Checking R installation...........OK
Version: 4.4.1
Path: /opt/homebrew/Cellar/r/4.4.1/lib/R
LibPaths:
- /opt/homebrew/lib/R/4.4/site-library
- /opt/homebrew/Cellar/r/4.4.1/lib/R/library
knitr: 1.47
rmarkdown: 2.27
[✓] Checking Knitr engine render......OK
The text was updated successfully, but these errors were encountered: