Skip to content

Commit

Permalink
fix google chrome args cf #10627
Browse files Browse the repository at this point in the history
  • Loading branch information
cscheid committed Aug 29, 2024
1 parent 06f3f75 commit 8935c1c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/test-ff-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ jobs:
if: ${{ runner.os == 'Linux' }}
run: |
echo $(which chromium-browser)
$(which chromium-browser) --headless https://www.chromestatus.com
$(which chromium-browser) --headless --no-sandbox --disable-gpu --renderer-process-limit=1 https://www.chromestatus.com
shell: bash

- name: Run all Smoke Tests Windows
Expand Down

1 comment on commit 8935c1c

@cderv
Copy link
Collaborator

@cderv cderv commented on 8935c1c Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not enough, in the sense that there is other bug with new --headless=new becoming the default in latest chrome.
We should probably remove this - let's see what CI says: https://github.com/quarto-dev/quarto-cli/actions/runs/10622241825/job/29446047211

Please sign in to comment.