Merge pull request #10166 from quarto-dev/bugfix/10165

lua, shortcodes - don't remove attribute values that don't match lpeg expression

src/resources/filters/customnodes/shortcodes.lua

@@ -227,6 +227,10 @@ function shortcodes_filter()
       return pandoc.utils.stringify(result) 
     end, 
   })
+  local function apply_code_shortcode(text)
+    return shortcode_lpeg.wrap_lpeg_match(code_shortcode, text) or text
+  end
+
   local filter
 
   local block_handler = function(node)
@@ -261,14 +265,14 @@ function shortcodes_filter()
       return
     end
 
-    el.text = shortcode_lpeg.wrap_lpeg_match(code_shortcode, el.text)
+    el.text = apply_code_shortcode(el.text)
     return el
   end
 
   local attr_handler = function(el)
     for k,v in pairs(el.attributes) do
       if type(v) == "string" then
-        el.attributes[k] = shortcode_lpeg.wrap_lpeg_match(code_shortcode, v)
+        el.attributes[k] = apply_code_shortcode(v)
       end
     end
     return el
@@ -302,12 +306,12 @@ function shortcodes_filter()
         RawInline = code_handler,
         Image = function(el)
           el = attr_handler(el)
-          el.src = shortcode_lpeg.wrap_lpeg_match(code_shortcode, el.src)
+          el.src = apply_code_shortcode(el.src)
           return el
         end,
         Link = function(el)
           el = attr_handler(el)
-          el.target = shortcode_lpeg.wrap_lpeg_match(code_shortcode, el.target)
+          el.target = apply_code_shortcode(el.target)
           return el
         end,
         Span = function(el)

tests/docs/smoke-all/2024/06/27/10165.qmd

@@ -0,0 +1,13 @@
+---
+title: test
+_quarto:
+  tests:
+    html:
+      ensureHtmlElements:
+        - ["img[alt='']", "img#second[alt='']"]
+        - []
+---
+
+![]({{< placeholder >}}){width=45 alt=""}
+
+![](foo.png){#second width=45 alt=""}