Refactoring application to share a singular settings structure #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
commented
Apr 4, 2024
jordens
reviewed
Apr 4, 2024
ryan-summers
commented
Apr 5, 2024
jordens
previously approved these changes
Apr 5, 2024
This was
linked to
issues
Apr 5, 2024
|
@jordens How do we want to manage this PR w.r.t rust-embedded-community/menu#18? I can lock us to a specific commit now, and once we get |
Co-authored-by: Robert Jördens <[email protected]>
|
I'd run with the current menu git commit and adapt when that changes or lands. |
…er into feature/shared-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Stabilizer application to share a singular settings structure among the USB and MQTT interfaces. This means that configuration can be modified via both MQTT and USB concurrently. Saving settings will save the active settings to device flash memory for persistence.