Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic USB implementation #789

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Adding basic USB implementation #789

merged 5 commits into from
Oct 16, 2023

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Oct 13, 2023

Adding a PR for basic USB terminal support.

For some reason, this isn't working yet on Windows (descriptor rquests are failing and windows can't recognize the device).

I suspect something's going wrong in the configuration of the peripheral and am still investigating.

Current USB interface is an echo chamber:

PS C:\Users\rsummers> python -m serial COM22
--- Miniterm on COM22  9600,8,N,1 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
echo: a
echo: s
echo: d
echo: f
echo: s
echo: a
echo: s
echo: d
echo: f
echo: s
echo: a

@ryan-summers
Copy link
Member Author

The USB enumeration issue appears to be a result of rust-embedded-community/usb-device#128 - I'll submit a patch to usb-device to get this fixed.

@ryan-summers ryan-summers requested a review from jordens October 13, 2023 15:19
@ryan-summers ryan-summers marked this pull request as ready for review October 13, 2023 15:19
@ryan-summers
Copy link
Member Author

The intent is to follow-up with an actual settings interface in the future now that we have a USB interface, and then use the sequential-storage crate to store values in the unused flash. This supports #351

src/hardware/serial_terminal.rs Outdated Show resolved Hide resolved
src/hardware/serial_terminal.rs Outdated Show resolved Hide resolved
src/hardware/serial_terminal.rs Outdated Show resolved Hide resolved
src/hardware/setup.rs Outdated Show resolved Hide resolved
src/hardware/serial_terminal.rs Outdated Show resolved Hide resolved
@ryan-summers ryan-summers requested a review from jordens October 16, 2023 09:34
@jordens jordens added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 041d33c Oct 16, 2023
8 of 9 checks passed
@ryan-summers ryan-summers deleted the feature/usb-support branch October 16, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants