Handle bad length in header #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-summers
requested changes
Nov 23, 2023
madmo
changed the title
ryan-summers
requested changes
Dec 1, 2023
There was a problem hiding this comment.
It looks like this is protecting against an issue where the packet-header of the MQTT datagram may be corrupt and indicate a much larger size than we support, which we obviously should not use to index into self.buffer, so this is definitely a bug. Thanks for the fix here!
Can you please:
- Add an entry to CHANGELOG.md indicating this defect has been fixed?
- Fix the style formatting?
return error instead of panicing
Sure, updated the CHANGELOG. Thanks for reviewing! |
ryan-summers
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a panic in
fn receive_bufferif a packet with a too big length is received.