Feature/self tests #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordens
requested changes
Aug 19, 2020
src/chassis_fans.rs
Outdated
| // If 5 fans (the count mounted on the chassis) spun up to a nominal high speed RPM, 5-6 | ||
| // fans were at a nominal low RPM, and 6 fans were not spinning when powered down, fans are | ||
| // operating nominally. | ||
| (fans_spun_high == 5) && (fans_spun_low >= 6) && (fans_powered_down == 6) |
There was a problem hiding this comment.
Reading the comment:
Suggested change
| (fans_spun_high == 5) && (fans_spun_low >= 6) && (fans_powered_down == 6) | |
| (fans_spun_high == 5) && (fans_spun_low >= 5) && (fans_powered_down == 6) |
There was a problem hiding this comment.
I've updated it such that low spinup requires a non-zero RPM and have slightly reworked this logic.
There was a problem hiding this comment.
IMO verifying that the 1.0 duty cycle having high RPM and then going back to 0.1 duty (and later with feedback) would be enough.
src/chassis_fans.rs
Outdated
| let fans_powered_down = | ||
| dead_rpms | ||
| .iter() | ||
| .fold(0, |count, rpms| if *rpms == 0 { count + 1 } else { count }); |
There was a problem hiding this comment.
Isn't that just:
Suggested change
| .fold(0, |count, rpms| if *rpms == 0 { count + 1 } else { count }); | |
| .filter(|rpms| *rpms == 0).count(); |
For the two others below as well.
There was a problem hiding this comment.
I knew there had to be a better way. Thanks for pointing to filter(). I'm still getting used to rust iterators.
jordens
approved these changes
Aug 19, 2020
|
Agreed on the boot delay. If this becomes annoying during development just bypass it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a number of self-tests to booster's I2C devices that run at startup.
Tests include:
@jordens The downside of testing fan RPMs on boot is that we need a pretty significant settling time on the fans, which results in a longer boot time. We could likely simplify the fan tests to speed it up if desired.
This closes #38