Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create security-authorization-of-web-endpoints-reference.md #1616

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Create security-authorization-of-web-endpoints-reference.md #1616

merged 1 commit into from
Sep 16, 2024

Conversation

MichalMaler
Copy link
Contributor

Renaming file to match the documentation changes
quarkusio/quarkus#30549

** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **

@MichalMaler MichalMaler mentioned this pull request Jan 23, 2023
Merged
@github-actions
Copy link

🎊 PR Preview 435711c has been successfully built and deployed to https://quarkus-io-pr-1616-preview.surge.sh

@michelle-purcell
Copy link
Contributor

@MichalMaler - The original pre-diataxis published version topic was called `security-authorization.adoc'.

A redirect file named security-authorization.md will also be needed for the original source page URL.
Thanks

@maxandersen
Copy link
Member

is this still relevant?

@MichalMaler
Copy link
Contributor Author

MichalMaler commented Sep 9, 2024 •
edited
Loading

is this still relevant?

Hello, Max,
yes, it is. Let me apply these comments.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@rolfedh
Copy link
Contributor

rolfedh commented Sep 10, 2024

Hi @MichalMaler, I noticed the file uses an .adoc file extension, while the other most recent updated files use .md, so I recommend updating it to use .md instead.
The contents of the file follow the same structure as the other files in the _redirects/guides directory. So the redirect should function correctly once it's deployed to the community website.

@MichalMaler MichalMaler changed the title Create security-authorization-of-web-endpoints-reference.adoc Create security-authorization-of-web-endpoints-reference.md Sep 16, 2024
@rolfedh
Copy link
Contributor

rolfedh commented Sep 16, 2024

LGTM

@MichalMaler @michelle-purcell
Create security-authorization-of-web-endpoints-reference.md
04e7aee 
Renaming file to match the documentation changes
quarkusio/quarkus#30549

Apply suggestions from code review

Co-authored-by: Michelle Purcell <[email protected]>
@MichalMaler
Copy link
Contributor Author

@maxandersen @jmartisk Hello! Can one of you merge this? :)

@jmartisk jmartisk merged commit f0449e3 into quarkusio:main Sep 16, 2024
1 check passed
@MichalMaler MichalMaler deleted the patch-1 branch September 17, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle-purcell michelle-purcell michelle-purcell left review comments

@jmartisk jmartisk jmartisk approved these changes

@rolfedh rolfedh rolfedh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichalMaler @michelle-purcell @maxandersen @rolfedh @jmartisk