fix: getting started commands with jbang #1307
Conversation
|
im making update to cli guide to reflect this too |
|
🎊 PR Preview 665dd06 has been successfully built and deployed to https://quarkusio-quarkusio-github-io-preview-pr-1307.surge.sh 🕐 Build time: 0.012s
🤖 By surge-preview |
Details in quarkusio/quarkusio.github.io#1307 on why the "trust" call is added. I moved jbang up as it is the only one that works on every OS and without java first installed. Thus absolute fastest/simplest to use on all major OS's. And moved homebrew down as that is only available for mac/osx.
|
guide fix is at quarkusio/quarkus#23134 |
| <h4>For Linux, macOS, and Windows (using WSL or bash compatible shell like Cygwin or MinGW)</h4> | ||
| <div class= "highlighter-rouge"> | ||
| <div class="highlight"> | ||
| <pre class="highlight"><code> | ||
| curl -Ls https://sh.jbang.dev | bash -s - trust add https://repo1.maven.org/maven2/io/quarkus/quarkus-cli/ |
There was a problem hiding this comment.
This step should be separated out and (briefly) explained. Ubuntu uses words like this to explain adding additional repos/keys (using installation of mongo as an example):
From a terminal, issue the following command to import the MongoDB public GPG Key from ...
wget -qO - https://www.mongodb.org/static/pgp/server-5.0.asc | sudo apt-key add -The operation should respond with an OK code.
Something like this (but about adding Quarkusio as a trusted source) would suffice.
There was a problem hiding this comment.
That feels like overkill. You want the same for brew tap add?
It is effectively the same - a command to indicate you are okey installing from a specific location.
It's intended you can copy and paste to just install.
There was a problem hiding this comment.
you still just copy and paste to install. But it lets people know what they're doing and what they are trusting. You can keep it compact if you wish, but there are two commands there, and the first (as it involves trust) should be explained.
Details in quarkusio/quarkusio.github.io#1307 on why the "trust" call is added. I moved jbang up as it is the only one that works on every OS and without java first installed. Thus absolute fastest/simplest to use on all major OS's. And moved homebrew down as that is only available for mac/osx.
Details in quarkusio/quarkusio.github.io#1307 on why the "trust" call is added. I moved jbang up as it is the only one that works on every OS and without java first installed. Thus absolute fastest/simplest to use on all major OS's. And moved homebrew down as that is only available for mac/osx. (cherry picked from commit 881fbbb)
Fixing this based on quarkusio/quarkus#22723 The issue here is that if you are BRAND NEW user you don't have trusted the location quarkusio jbang catalog fetches its jars from. i.e. you have no `~/.jbang/trusted-sources.json` Thus if you run this command first: `curl -Ls https://sh.jbang.dev | bash -s - app install --fresh --force quarkus@quarkusio` jbang will ask you to trust BUT curl via pipe result in no tty being available, i.e. user can not say/answer yes; thus until jbang 0.86 we delayed that question until you actually try and run the installed script - but as seen in #22723 that confuses people too. So in jbang 0.87 I made it so `jbang app install` will ask you for trust, but it does not fix the first install as here you still don't have a tty to ask user. Thus this PR adds explicit call for trust. Then it works for initial user too.
|
🙈 The PR is closed and the preview is expired. |
Fixing this based on quarkusio/quarkus#22723
To test this ensure you do not have ~/.jbang/trusted-sources.json in you file system or at least no trust of maven central.
The issue here is that if you are BRAND NEW user you don't have
trusted the location quarkusio jbang catalog fetches its jars from.
i.e. you have no
~/.jbang/trusted-sources.jsonThus if you run this command first:
curl -Ls https://sh.jbang.dev | bash -s - app install --fresh --force quarkus@quarkusiojbang will ask you to trust BUT curl via pipe result in no tty being available, i.e. user
can not say/answer yes; thus until jbang 0.86 we delayed that question until
you actually try and run the installed script - but as seen in #22723
that confuses people too.
So in jbang 0.87 I made it so
jbang app installwill ask you for trust,but it does not fix the first install as here you still don't have a tty to ask user.
Thus this PR adds explicit call for trust. Then it works for initial user too.
** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **