Website 2.0 #1207
Closed
Website 2.0 #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committing my new version of the site to back up files off my hard drive and to share with
maxandersen
reviewed
Nov 15, 2021
Comment on lines
+13
to
+15
| <pre class="highlight"><code> | ||
| curl -Ls https://sh.jbang.dev | bash -s - app install --fresh --force quarkus@quarkusio | ||
| </code></pre> |
There was a problem hiding this comment.
Suggested change
| <pre class="highlight"><code> | |
| curl -Ls https://sh.jbang.dev | bash -s - app install --fresh --force quarkus@quarkusio | |
| </code></pre> | |
| <pre class="highlight"><code>curl -Ls https://sh.jbang.dev | bash -s - app install --fresh --force quarkus@quarkusio</code></pre> |
all the code sections should not have start/end empty lines as that result in "copy" button giving you 3 lines instead of 1 which most terminals complains about.
maxandersen
reviewed
Nov 15, 2021
maxandersen
reviewed
Nov 15, 2021
maxandersen
reviewed
Nov 15, 2021
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
do we wanna continue doing this event approach or instead just use the Event category on github discussions? or some mix?
There was a problem hiding this comment.
I was thinking a mix since we already have the world tour on the site. We could use the site to list major events we are attending/sponsoring but use the GH Discussion section for additional communication.
I've removed the extensions section from the navigation and the corresponding files from the build so they won't be generated. I also added a section to the top of the new getting started page that defines the Quarkus pre-requests.
Updated Events section content., Updated training to include link to discussions, updated getting started to include pre-requests.
Apply suggestions from code review Co-authored-by: Guillaume Smet <[email protected]>
…or the JWT guide from the web category Signed-off-by: Nathan Erwin <[email protected]>
I've removed the extensions section from the navigation and the corresponding files from the build so they won't be generated. I also added a section to the top of the new getting started page that defines the Quarkus pre-requests.
Updated Events section content., Updated training to include link to discussions, updated getting started to include pre-requests.
…b.io into Website-2.0
|
😭 Deploy PR Preview e87f744 failed. Build logs
🤖 By surge-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **