Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jpa] Add support for @Embeddable, @Embedded, superclass and interfaces #6

Merged
merged 2 commits into from
Aug 6, 2018
Merged

[jpa] Add support for @Embeddable, @Embedded, superclass and interfaces #6

merged 2 commits into from
Aug 6, 2018
+248 −15

Conversation

emmanuelbernard
Copy link
Member

No description provided.

@emmanuelbernard emmanuelbernard requested a review from Sanne August 6, 2018 12:27
@emmanuelbernard emmanuelbernard changed the title [jpa] Add support for @Embeddable and @Embedded [jpa] Add support for @Embeddable, @Embedded, superclass and interfaces Aug 6, 2018
@emmanuelbernard
Copy link
Member Author

@Sanne I've added support for superclasses and interfaces (adding to the reflective list).
@stuartwdouglas I had to be a bit creative in my understanding of Jandex, I would not mind if you could review my usage of it in JPAAnnotationProcessor.

Thanks!

@stuartwdouglas stuartwdouglas merged commit 74dabb9 into quarkusio:master Aug 6, 2018
@cescoffier cescoffier added this to the 0.1.0 milestone Jan 21, 2019
mswiderski pushed a commit to mswiderski/quarkus that referenced this pull request Jun 14, 2019
@mariofusco
Merge pull request quarkusio#6 from mswiderski/kogito-ext2
c2dc7be 
incorporated guide feedback
@maxandersen maxandersen mentioned this pull request Mar 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Awaiting requested review from Sanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emmanuelbernard @stuartwdouglas @cescoffier